Update to AndroidX, gradle version and plugin updates

onaio / kujaku

Mapping and check-in library for Android using MapBox SDK

https://ona.io

BSD 2-Clause "Simplified" License

18 stars 11 forks source link

Update to AndroidX, gradle version and plugin updates #357

Closed ekigamba closed 2 years ago

ekigamba commented 2 years ago

Update to Mapbox v9
Update to AndroidX
Update AGP to 7.1.3

Reduced coverage by 10%

Jacoco has a known bug that results in no coverage generation when buildType.debug.testCoverageEnabled is set to true. With this option set to false, gradle does not find the task 'createDebugCoverageReport which is used to run instrumentation tests with coverage reporting. These tests contribute to a fraction of the test coverage.

Below is the difference especially in the sample module where the tests are mostly instrumentation tests Screenshot from 2022-08-22 18-11-48 Before

Screenshot from 2022-08-22 18-11-38 After

This is being tracked here

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build #584

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-9.4%) to 44.187%

Totals
Change from base Build #582:	-9.4%
Covered Lines:	2611
Relevant Lines:	5909

💛 - Coveralls

ndegwamartin commented 2 years ago

The PR looks good for merge, however I think we should create a ticket around reporting the Instrumentation coverage. cc @ekigamba

ekigamba commented 2 years ago

The PR looks good for merge, however I think we should create a ticket around reporting the Instrumentation coverage. cc @ekigamba

I agree. Here is the ticket https://github.com/onaio/kujaku/issues/358