onaio / rdt-standard

RDT Open Guidelines Application
Apache License 2.0
1 stars 5 forks source link

Error while filling in Travel and Contact Exposure form #735

Open mwkhan1983 opened 3 years ago

mwkhan1983 commented 3 years ago

Though all of the responses are provided in a form, it still shows the error and did not let the user proceed.

https://user-images.githubusercontent.com/69383347/105813684-06653900-5fd2-11eb-9dd2-f023dc5ec43c.mp4

mwkhan1983 commented 3 years ago

@ellyasafaa

ellyasafaa commented 3 years ago

Hi, is there any update on this. Also replicated on Sign and Symptom form on Redmi 5 Plus, Android 7.1.2

vincent-karuri commented 3 years ago

@ellyasafaa Could you post a video showing the process of filling in this step information i.e. one showing the user clicking through the items on a fresh page before trying to submit?

ellyasafaa commented 3 years ago

@vincent-karuri Our study phone is having Android 10, so I can't take the video at the time. Will get back to you after having the video from the Android 7 user.

vincent-karuri commented 3 years ago

@ellyasafaa were you able to get this https://github.com/onaio/rdt-standard/issues/735#issuecomment-768902527 for the redmi phone? It would be helpful in reproducing the bug.

ellyasafaa commented 3 years ago

@vincent-karuri I saw it replicated twice at the time when the Redmi phone reported, but it wasn't replicated after that by the user. I have tried also on Android 8 and 9 that currently I have, but it is not replicated yet. Will do double-check after I have the other devices with Android lower than 10. But, I have the Android 10 phone with me and it is replicated here, would the Android version affect that error?

vincent-karuri commented 3 years ago

@ellyasafaa I don't think it's related to Android version but we'd want to replicate it on the supported Android versions first.

ellyasafaa commented 3 years ago

Hi Vincent, just got this issue again on Samsung Galaxy J5 Pro Android 9. https://drive.google.com/file/d/1y8qWwS8XtW18tym9AU2yAWJvjS67UBf2/view?usp=sharing

ellyasafaa commented 3 years ago

And on Redmi 5 Plus Android 7.1.2 https://drive.google.com/file/d/10AH4UHVcgNPX8bJPOgDwqkFKvhkEipEP/view?usp=sharing

mwkhan1983 commented 3 years ago

@syedowaisali90 are you able to replicate this issue?

owais-vd commented 3 years ago

@mwkhan1983 @ellyasafaa I'm on it. Trying to reproduce

mwkhan1983 commented 3 years ago

@ellyasafaa we need to get a video showing how you transition from the previous page and start filling out a fresh page and show us the bug appearing. Currently in video form is shown filled.

I have tried on my android 10 Xiomi device and didn't get an issue. Will try and post the video

ellyasafaa commented 3 years ago

My apologies for the late reply. Yes, I have tried as well, but when I take the video to start filling out a fresh page is not happening. When I tried again, it is happening. I don't know what causes that because it randomly happened. But I think I found out one of the causes, it will happen if we accidentally press the back button on our devices.

For example, I have reached the travel and contact exposure form and accidentally press the back button on my device. The sign and symptom page will have the error message if I click continue. That is I think the process when I get the bugs on the Sign & symptom form. On the other hand, it happened randomly on Travel and Contact exposure without experiencing the same process as on the Sign & Symptom form.

owais-vd commented 3 years ago

@ellyasafaa I have found the problem it was a bug in the native-form library and that was fixed by @bennsimon in this PR https://github.com/OpenSRP/opensrp-client-native-form/pull/538.

Here is changed https://github.com/OpenSRP/opensrp-client-native-form/pull/538/files#diff-8530cda4bb9465728111d451b62b40eba88c0d1827a60f159b3f8e71571fc1e6

But in RDT we don't have the latest version of the native-form library so we need to finalize this PR https://github.com/onaio/rdt-standard/pull/591 first.

@vincent-karuri @mwkhan1983

ellyasafaa commented 3 years ago

@syedowaisali90 great work on that! let's have that finalized!

ellyasafaa commented 3 years ago

@syedowaisali90 Hi, what is the status of this?

owais-vd commented 3 years ago

@ellyasafaa We couldn't fix this issue in the next release. We will have to wait because we have a lot of change in native-form migration that needs to be passed on QA and ensure that nothing is a break

ellyasafaa commented 3 years ago

@syedowaisali90 @mwkhan1983 please find the issue to be solved as well.