search

onaio / rdt-standard

RDT Open Guidelines Application
Apache License 2.0
1 stars 5 forks source link

Not allowing enter in the answer field on the new client record form #946

Closed sid-yussin closed 3 years ago

sid-yussin commented 3 years ago

close #907

vincent-karuri commented 3 years ago

@yussin-hidayat does enter here mean space?

sid-yussin commented 3 years ago

@yussin-hidayat does enter here mean space?

No, newline. Its "enter" button on keyboard.

vincent-karuri commented 3 years ago

@yussin-hidayat does enter here mean space?

No, newline. Its "enter" button on keyboard.

And adding a space to the regex achieves this?

sid-yussin commented 3 years ago

@yussin-hidayat does enter here mean space?

No, newline. Its "enter" button on keyboard.

And adding a space to the regex achieves this?

No, the point is regex that contains any chars except newline. The regex that I added is specific to name and ID.

vincent-karuri commented 3 years ago

Sorry, I'm still confused https://github.com/onaio/rdt-standard/issues/907#issue-827124709 is talking about enter being allowed. What is it that's happening right now which we want to remove/modify? How is it related to the regex changes in this pr?

sid-yussin commented 3 years ago

Sorry, I'm still confused #907 (comment) is talking about enter being allowed. What is it that's happening right now which we want to remove/modify? How is it related to the regex changes in this pr?

Can I disable enter without regex?

vincent-karuri commented 3 years ago

Sorry, I'm still confused #907 (comment) is talking about enter being allowed. What is it that's happening right now which we want to remove/modify? How is it related to the regex changes in this pr?

Can I disable enter without regex?

Is the objective to not allow users to press enter? What other existing field exhibits the behavior you want to implement? Could you post a link to it?

sid-yussin commented 3 years ago

Sorry, I'm still confused #907 (comment) is talking about enter being allowed. What is it that's happening right now which we want to remove/modify? How is it related to the regex changes in this pr?

Can I disable enter without regex?

Is the objective to not allow users to press enter? What other existing field exhibits the behavior you want to implement? Could you post a link to it?

https://github.com/onaio/rdt-standard/blob/ca96bf0638b078fd7f35d93fae771863b79da619/rdt-open-reader/src/covidIndonesia/assets/json.form/patient-diagnostics-form-original.json#L1046