search

onaio / rdt-standard

RDT Open Guidelines Application
Apache License 2.0
1 stars 5 forks source link

User tied to health facility A should not be able to see data entered by user tied to health facility B #957

Closed sid-yussin closed 3 years ago

sid-yussin commented 3 years ago

close #931

vincent-karuri commented 3 years ago

@mwkhan1983 @syedowaisali90 when the pr changes are complete here, I'll need your help testing this functionality on the app.

We'll need to build 2 APKs from the flavors, one for the supervisor app and another for regular app (what we have currently as https://github.com/onaio/rdt-standard/blob/42662cc88d98c458249c2d3d3144f9c9a5454b7e/rdt-open-reader/build.gradle#L129). Then verify that the supoervisor app syncs by location and the regular app syncs by team.

sid-yussin commented 3 years ago

@vincent-karuri sorry, we don't want to have more than one apk. If this is not possible, I think you can close this issue.

vincent-karuri commented 3 years ago

@vincent-karuri sorry, we don't want to have more than one apk. If this is not possible, I think you can close this issue.

@yussin-hidayat You can still have a single app that syncs by location for everyone (regular users and supervisors), but that's a decision you'll need to make based on your specific requirements.

If this is still not necessary, please close the PR with a note of why it's no longer relevant.

sid-yussin commented 3 years ago

Not relevant.