search

onaio / steps-app

WHO STEPS App
Apache License 2.0
2 stars 2 forks source link

Second round of QA for the android app #137

Closed owais-vd closed 2 years ago

owais-vd commented 2 years ago

Fixed #136

This PR will be covered point number 1, 3 and 5 based on this comment https://github.com/onaio/steps-app/issues/136#issuecomment-1015371823.

Point number 6 is already covered in this PR https://github.com/onaio/steps-app/pull/131

owais-vd commented 2 years ago

Hi @ekigamba i saw your comments you have more concerns about the status like how we manage the status of when we submit the survey.

Let me try to explain how we manage the status and when to show the cloud icon.

Previously we need to show the cloud icon on all those records that have been submitted by the ODK app. Therefore, i have created a new status called SUBMITTED and created a class DataSubmissionResultHandler in the steps app which was responsible to find all those records that have submitted status and then updating the household and the participant status to SUBMITTED.

Now, according to the new requirement, we need to show the cloud icon on all those households that have been uploaded to the steps server either the status DONE or NOT_REACHABLE or whatever. Therefore, in that case, we don't have to confirm the status from the ODK app that's why i have updated the implementation. check the @akahure comment here https://github.com/onaio/steps-app/issues/136#issuecomment-1017497397