search

onaio / steps-app

WHO STEPS App
Apache License 2.0
2 stars 2 forks source link

Canceling the selection of a participant for a size 1 household makes the household Not reachable #157

Closed bkimondiu closed 2 years ago

bkimondiu commented 2 years ago

Cancelling the selection of a participant for a household of size 1 adds the household to the Not reachable category. Should this be the correct workflow?

Steps to replicate:

  1. Create a household
  2. Add one household member
  3. Move to select a participant
  4. After the participant is selected, cancel the selection The household data submitted for this household shows the status as CANCEL_SELECTION and not NOT_REACHABLE as shown below Screenshot 2022-03-28 at 18 21 48

For households of size >1, cancelling the selection reverts to the original household members list for participant selection to happen again.

owais-vd commented 2 years ago

image we have another option to mark as NOT REACHABLE above the CANCEL SELECTION

bkimondiu commented 2 years ago

@owais-vd Yes. That is correct. I was raising this as a bug that when you have a household of size one (1), and you select the participant and later on cancel the selection, the status of the household is set to NOT REACHABLE on the app yet when you submit the household data, the status on the web app is set to CANCEL_SELECTION. Please follow the steps here to replicate the bug.

owais-vd commented 2 years ago

if we cancel the selection that means we can re-select the member again but if we set the household status NOT REACHABLE on cancelation that means we cannot be done the selection again. However, in the Total summary screen, we are merging the cancelation count in the NOT REACHABLE category. Please check the second option of this comment https://github.com/onaio/WHOSteps/issues/16#issuecomment-913503870

bkimondiu commented 2 years ago

This issue is no longer valid. Tested it again with @owais-vd and it works as expected.