search

onaio / steps-app

WHO STEPS App
Apache License 2.0
2 stars 2 forks source link

Add phone number validation #159

Closed owais-vd closed 2 years ago

owais-vd commented 2 years ago

close #155

owais-vd commented 2 years ago

Looks good. I think we may need to hold of on merging this until we get sign off from the client that we should validate this number for minimum/maximum length.

sure

owais-vd commented 2 years ago

are we going to have this PR or we will still wait? cc: @ukanga @bkimondiu

bkimondiu commented 2 years ago

@owais-vd We should wait. I will send let you know what the client says about this one.

bkimondiu commented 2 years ago

@owais-vd @ukanga The client was not keen on this validation. It's not a required field and can be left empty. We can disregard adding this validation since they won't be using this phone number data.

ukanga commented 2 years ago

Noted.