Closed owais-vd closed 2 years ago
Log.i
and Log.e
calls. let's replace all of them with Timber
which can disable certain logs for release APKs https://github.com/onaio/steps-app/search?p=2&q=Log and https://github.com/onaio/steps-app/search?q=Loggerandroid.util.Log
- I see we still have
Log.i
andLog.e
calls. let's replace all of them withTimber
which can disable certain logs for release APKs https://github.com/onaio/steps-app/search?p=2&q=Log and https://github.com/onaio/steps-app/search?q=Logger
I've checked but have not found any Log.i
and Log.e
in change. I think the search is not coming from change and the Logger class will removed in this PR https://github.com/onaio/steps-app/pull/205
- Remove the unused imports for
android.util.Log
Removed.
@owais-vd I think we need to remove these usages of Logger
and the Logger file. Create an issue to reference the old version of the Logger
file in commit. We will consult further to understand the purpose for logging to file
@owais-vd Sorry about that, I had forgotten that Github search only works on master
@owais-vd I think we need to remove these usages of
Logger
and the Logger file. Create an issue to reference the old version of theLogger
file in commit. We will consult further to understand the purpose for logging to file
Logger issue is tracking here https://github.com/onaio/steps-app/issues/198 and also created a PR https://github.com/onaio/steps-app/pull/205
close #202