onaio / superset-patchup

Superset-patchup is a python package that "patches" Superset to add custom functionality that we find to be useful
https://canopyinsights.com
Apache License 2.0
8 stars 7 forks source link

Replace oauth_user_info with custom getter method #18

Open moshthepitt opened 5 years ago

moshthepitt commented 5 years ago

In flask appbuilder it seems that they suggest the correct way to provide a custom user info getter method is as below:

@appbuilder.sm.oauth_user_info_getter
def my_oauth_user_info(sm, provider, response=None):
    if provider == 'github':
        me = sm.oauth_remotes[provider].get('user')
        return {'username': me.data.get('login')}
    else:
        return {}

We need to investigate if indeed this is the recommended approach and then implement it if so.