search

onaio / superset-patchup

Superset-patchup is a python package that "patches" Superset to add custom functionality that we find to be useful
https://canopyinsights.com
Apache License 2.0
8 stars 7 forks source link

OLIMS-6504: Added oauth-init endpoint for auto-approve mechanism #37

Closed dserkowski closed 5 years ago

dserkowski commented 5 years ago

In order to implement the auto-approving mechanism, we need to extend the patchup. The changes add the endpoint which simplifies OAuth sign-in process.

Please, review and merge it. What I have noticed, you usually increment the version number and add a tag after adding new functionality. Could you do this also for these changes, so that I can point them in Superset?

dserkowski commented 5 years ago

@moshthepitt, I have added docstrings and tests, as you requested.

dserkowski commented 5 years ago

If these changes are ok and you are ready to merge this (and add a tag), please do this. I am waiting for these changes, so it blocks me. Thank you in advance.

moshthepitt commented 5 years ago

@dserkowski I anticipate that this will be merged (and a release made) early Monday. Thanks!

dserkowski commented 5 years ago

Ok, give me some time. I will install tox and fix it

dserkowski commented 5 years ago

Done. @moshthepitt, could you rerun the CI?

moshthepitt commented 5 years ago

@dserkowski merged and tagged a new release: https://github.com/onaio/superset-patchup/releases/tag/v0.1.5

Thank you!

dserkowski commented 5 years ago

Thank you very much!