search

onaio / tally-ho

Election results data entry and verification software.
http://tally-ho.readthedocs.org/en/latest/
Other
19 stars 21 forks source link

Add sub constituency code column #381

Closed lincmba closed 1 year ago

lincmba commented 1 year ago

Add sub constituency code column to the candidates final results report

Fixes https://github.com/onaio/tally-ho/issues/367

codecov-commenter commented 1 year ago

Codecov Report

Merging #381 (0df4c5d) into master (7a3c66e) will increase coverage by 0.41%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   66.89%   67.30%   +0.41%     
==========================================
  Files         123      123              
  Lines        7537     7491      -46     
==========================================
  Hits         5042     5042              
+ Misses       2495     2449      -46
Impacted Files Coverage Δ
...ally/views/reports/administrative_areas_reports.py 33.43% <0.00%> (+1.51%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

lincmba commented 1 year ago

Should this change https://github.com/onaio/tally-ho/blob/master/tally_ho/settings/common.py#L351

JohnMwashuma commented 1 year ago

Should this change https://github.com/onaio/tally-ho/blob/master/tally_ho/settings/common.py#L351

Not for now at least. These two issues https://github.com/onaio/tally-ho/issues/372 https://github.com/onaio/tally-ho/issues/375 will update all the required columns.