onaio / tally-ho

Election results data entry and verification software.
http://tally-ho.readthedocs.org/en/latest/
Other
19 stars 21 forks source link

Working skeleton of the tab separated turnout reports #409

Closed JohnMwashuma closed 1 year ago

JohnMwashuma commented 1 year ago

Context


This is a working skeleton of the turnout report described in these docs. https://docs.google.com/spreadsheets/d/1YnykTc6-MYjokM15VRmZcSWnBS-JESA1eTEhDEivVu8/edit#gid=1805275455 https://docs.google.com/document/d/151tS0rlJpywFSrLDmr-Gtmz6PSNApv_Vbz67IsWbdX8/edit

This work was to test if it's possible to have the reports in one page and tab separated, which we've managed to do. Also due to the complexity of the report queries, specifically finding voters voted in the counted stations we had to use plain functional views so that we can return a list of dictionary objects. This means we do not have the inbuilt functions provided by django datatables lib e.g. page size changes, page changes e.t.c. However these shouldn't be hard to build.

That said, I think we can build on top of this work and finish the pending items.

Task check list


codecov-commenter commented 1 year ago

Codecov Report

Merging #409 (adfb3f7) into 390-update-turnout-report (e1d8882) will decrease coverage by 0.56%. The diff coverage is 7.24%.

@@                      Coverage Diff                      @@
##           390-update-turnout-report     #409      +/-   ##
=============================================================
- Coverage                      68.16%   67.61%   -0.56%     
=============================================================
  Files                            124      124              
  Lines                           7580     7648      +68     
=============================================================
+ Hits                            5167     5171       +4     
- Misses                          2413     2477      +64     
Impacted Files Coverage Δ
tally_ho/urls.py 92.85% <ø> (ø)
...ally/views/reports/administrative_areas_reports.py 31.43% <7.24%> (-1.83%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more