onaluf / fate

Flexible Angular Text Editor
MIT License
37 stars 14 forks source link

Mention feature #47

Closed omidkh68 closed 5 years ago

omidkh68 commented 6 years ago

is that possible to use mention feature?

onaluf commented 6 years ago

If you mean <blockquote>, no, not yet. My idea was to add this as an example of how you can customize the editor to support any kind of element. I'll try to release the doc/code example soon.

omidkh68 commented 6 years ago

@onaluf No, in fact, I need the feature to select an user by putting @ in editor such as instagram.

onaluf commented 6 years ago

That's an even more interesting example. I'll write the example for that. If you want You can have a look at the way the link function is written, it will give you a basic outline of what needs to be done.

omidkh68 commented 6 years ago

@onaluf it's great if we can inject a service in editor to show menu list of users and each item in menu has the ability to click.

onaluf commented 6 years ago

So I've been working on an example of that and then I realized that what you wanted is probably not exactly what I was working on. I was adding a menu to the toolbar to let you pick you mention.

However, in this case, I think you wanted this to happen inline in the editor: When the user starts typing some special char (@ for example) we display a helper menu. To do that I will need to add this feature to the editor but I think it would be a very convenient thing to do ! I'll use this issue to add this feature.

I will push the repo with the example/doc for the custom toolbar entry.

omidkh68 commented 6 years ago

@onaluf Thank you so much, yes I'm looking for inline mode, is that ready to use or not yet?

onaluf commented 6 years ago

Quick update: I’m still working on this and it should be ready soonish... probably in the next week or two. Sorry but I haven’t had much bandwidth lately.

onaluf commented 5 years ago

I've implemented this feature (finally), to use it on the demo page you can start by typing @ and it will show a menu. To see the implementation detail you can look at all the files with the prefix example- in the repo. They should give you a good idea about what is needed.

If you're missing something or need some better explanation, just create a new issue!

onaluf commented 5 years ago

:tada: This issue has been resolved in version 1.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

omidkh68 commented 5 years ago

@onaluf

Thank you for complete this useful feature, Do you have a plan for navigate into mention menu by keyboard arrow keys?

onaluf commented 5 years ago

Yes I had that in mind but it needs some more work... I want it to be as flexible as possible for the implementers of custom contextual menus. I have a few issues to fix but after that I'll work on this!

onaluf commented 5 years ago

It's done, you can now use up/down/enter to manipulate the contextual menu.