search

onaluf / fate

Flexible Angular Text Editor
MIT License
37 stars 14 forks source link

Fix erasing undetected selection #86

Closed leandro-hermes closed 3 years ago

leandro-hermes commented 4 years ago

When mouse-selecting text and dragging selection outside the target, the click event isn't catched, so, selectionRange is undefined. This logic fix avoid enter this block and throwing an Error.

leandro-hermes commented 4 years ago

8c9f92c was accidentally pushed, however, it should be merged anyway

onaluf commented 4 years ago

Thanks a lot for you contribution. Can you please address the comment I made in the code and then rewrite you commit message to conform to https://github.com/semantic-release/semantic-release ?

In this case the first commit need to be marked as breaking since it changes the name of a public method.

leandro-hermes commented 4 years ago

I reverted the wrong commit, I will submit another PR for context reasons. Should I create a new PR for this bug fix with a commit message conforming semantic-release?

onaluf commented 3 years ago

:tada: This PR is included in version 2.3.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: