onatcipli / rename

The Rename CLI Tool is a utility designed to modify your Flutter project's AppName and BundleId across various platforms, such as iOS, Android, Macos, Linux, Windows and Web
https://pub.dev/packages/rename
MIT License
164 stars 39 forks source link

Issues in android when using tools:replace="android:label" #26

Closed subinsv closed 2 years ago

subinsv commented 2 years ago

The package seems to replace the first occurance of android:label keyword. It should match the tags and not the value.

original:

   <application
        tools:replace="android:label"
        android:label="App Name"
        ...

After rename:

  <application
        android:label="App Name"
        android:label="App Name"
onatcipli commented 2 years ago

thanks for reporting this I will try to include this one with the upcoming release ✌️

jjangga0214 commented 2 years ago

A similar issue. Maybe helpful to debug!

Screenshot from 2021-09-17 00-25-53

onatcipli commented 2 years ago

fixed with prerelease version please check

https://pub.dev/packages/rename/versions/2.0.0-dev.2

rename: ^2.0.0-dev.2