search

onatcipli / rename

The Rename CLI Tool is a utility designed to modify your Flutter project's AppName and BundleId across various platforms, such as iOS, Android, Macos, Linux, Windows and Web
https://pub.dev/packages/rename
MIT License
164 stars 39 forks source link

Renaming BundleID also Renames BundleID of iOS Extensions. #46

Open 10ndavis opened 1 year ago

10ndavis commented 1 year ago

I created an Extension for Awesome Notifications FCM and when using the rename package to set the BundleID of my Flutter app, it also modifies the BundleID of the extension.

Steps to repeat:

Results: All instances of PRODUCT_BUNDLE_IDENTIFIER in project.pbxproj are renamed, thus renaming all extensions in the process.

onatcipli commented 9 months ago

Hey @10ndavis , currently package doesn't support the flavor or any extensions but we will consider to add it in the future but for now it is not available.

10ndavis commented 9 months ago

@onatcipli that's fine, but that's not what i'm reporting. This is a bug, in that is is renaming extensions-- and should not.

OlehMysak commented 9 months ago

@10ndavis same problem, did you find any solution?

onatcipli commented 9 months ago

hey @OlehMysak @10ndavis , Can you have try with the latest version and let me know please?

Usage changed a little bit I recommend to have look to readme before using it.

pub.dev/packages/rename

OlehMysak commented 9 months ago

@onatcipli

Screenshot 2023-10-02 at 13 35 09 Screenshot 2023-10-02 at 13 35 39 Screenshot 2023-10-02 at 13 36 10

I updated to latest version, but have same issue

The bundleId changes not only in the runner, but also in OneSignalNotificationServiceExtension, and it should be like in the 3 photos, is it possible to somehow change it only in the runner, and for OneSignalNotificationServiceExtension (in my case) or register separately, or so that it changes only the main bundle, but that left .OneSignalNotificationServiceExtension

quyenvsp commented 7 months ago

I found alternative package working perfect and more correct.

https://github.com/OutdatedGuy/package_rename

chandrabezzo commented 6 months ago

Hi @onatcipli have you check package_rename_plus?

songpola commented 2 months ago

@chandrabezzo What's the difference between package_rename and (your) package_rename_plus?

chandrabezzo commented 1 month ago

@songpola the different is about the key override_old_package on iOS. So, we can safely renamed the bundle identifier from your another target like NotificationService, PushTemplateExtension, and etc. Related to the issue that raised.

songpola commented 1 month ago

@songpola the different is about the key override_old_package on iOS. So, we can safely renamed the bundle identifier from your another target like NotificationService, PushTemplateExtension, and etc. Related to the issue that raised.

Nice! This should be noted in your README too :)