search

onbloc / adena-wallet

Adena is a friendly browser extension wallet for the Gnoland blockchain.
http://adena.app/
GNU General Public License v3.0
27 stars 19 forks source link

feat: Naming service #571

Open thanhngoc541 opened 2 months ago

thanhngoc541 commented 2 months ago

What type of PR is this?

Feature

What this PR does:

Adds a naming service for wallets. Users can now register a domain name, which acts as a shortcut for their wallet address, at https://gno-naming-service.vercel.app/. The registered domain name will be displayed in the wallet and can be used in place of the wallet address.

This feature is currently available on the test4 network and will be rolled out to other networks soon.

jinoosss commented 2 months ago

Thank you for creating a PR 🙏

However, before i can review this PR, i need to discuss whether we should support this feature.

Adena aims for formal, standardised feature support for Gno.

I don't think you should create dependencies on services that are managed by a specific team or individual.

This PR seems to be for feature support for gno.land/r/varmeta/demo/v1/domain/resolver, should we support this specific feature?

jinoosss commented 2 months ago

cc @dongwon8247

dongwon8247 commented 2 months ago

Gno already has username. Why do we need this?