onc-healthit / onc-certification-g10-test-kit

ONC Certification (g)(10) Standardized API Tests
Apache License 2.0
32 stars 10 forks source link

FI-1995: Changes for HL7 validator v6.0.21 #449

Closed dehall closed 11 months ago

dehall commented 11 months ago

The validator wrapper is being upgraded to use the most recent version of the HL7 validator (6.0.21 as of now, see https://github.com/inferno-framework/fhir-validator-wrapper/pull/61), and that version of the validator produces some slightly different output compared to the version we previously used (5.6.93):

  1. Code displays that do not match the official display are now errors by default. This can be changed to match the old behavior with the environment variable "DISPLAY_ISSUES_ARE_WARNINGS" set to true.

  2. There's now an error message received when testing US Core 3.1.1 related to a constraint that cannot be met due to a bad profile, see message below. This was seen previously with slightly different text ( https://chat.fhir.org/#narrow/stream/179309-inferno/topic/Pulse.20Oximetry.20Flow.20Rate.20units )

Observation/313: Observation.component[0].value.ofType(Quantity): The code provided (http://unitsofmeasure.org#L/min) is not in the value set 'Vital Signs Units' (http://hl7.org/fhir/ValueSet/ucum-vitals-common%7C4.0.1), and a code from this value set is required: Unable to check whether the code is in the value set http://hl7.org/fhir/ValueSet/ucum-vitals-common%7C4.0.1

Because we're already ignoring/excluding certain validator messages I added this one to that list.

~This is marked as draft until we tag & release a new version of the validator wrapper. (Though technically these should be backwards compatible in the sense that nothing will happen if the environment variable is set on a library that doesn't support it, and ignoring the error message shouldn't have any unexpected effects either)~

Testing Guidance: Run the test suites against the inferno reference server and pointing to an updated version of the validator: https://github.com/inferno-framework/fhir-validator-wrapper/pull/61 Ensure all tests pass