onc-healthit / reference-ccda-validator

Deployable C-CDA Validator war source code. Use this repository to build and deploy a validator on your local environment.
BSD 2-Clause "Simplified" License
36 stars 37 forks source link

Updates for 2023 SVAP Vocab Validation #186

Closed netkraft closed 10 months ago

netkraft commented 11 months ago

Updated 2023 SVAP Vocab Validation changes

drbgfc commented 11 months ago

The following 2 expressions specify SHALL for vocabulary conformance, but are configured for SHOULD. Is there a reason for this inconsistency? There may be more issues, I only checked up until the 2nd issue below, which is probalby 8 or so down.

<!--b. This associatedEntity SHALL contain exactly one [1..1] code, which SHALL be selected from ValueSet Personal And Legal Relationship Role Type urn:oid:2.16.840.1.113883.11.20.12.1 DYNAMIC (CONF:4537-32985) -->

<expression xpathExpression="/v3:ClinicalDocument/v3:templateId[@root='2.16.840.1.113883.10.20.22.5.8' and @extension='2023-05-01']/ancestor::v3:ClinicalDocument[1]/v3:participant/v3:associatedEntity/v3:code[not(@nullFlavor)]">
    <validator>
        <name>ValueSetCodeValidator</name>
        <validationResultSeverityLevels>
            <codeSeverityLevel>SHOULD</codeSeverityLevel>
        </validationResultSeverityLevels>
        <allowedValuesetOids>2.16.840.1.113883.11.20.12.1</allowedValuesetOids>
    </validator>
</expression>

<!-- 
8. SHALL contain exactly one [1..1] value with @xsi:type="CD", where the code SHALL be selected from ValueSet Pregnancy Intention urn:oid:2.16.840.1.113762.1.4.1166.22 DYNAMIC (CONF:4537-26559).
-->
<expression xpathExpression="//v3:observation/v3:templateId[@root='2.16.840.1.113883.10.20.22.4.281' and @extension='2023-05-01']/ancestor::v3:observation[1]/v3:value[not(@nullFlavor) and ancestor::v3:section[not(@nullFlavor)]]">
    <validator>
        <name>ValueSetCodeValidator</name>
        <validationResultSeverityLevels>
            <codeSeverityLevel>SHOULD</codeSeverityLevel>
        </validationResultSeverityLevels>
        <allowedValuesetOids>16.840.1.113762.1.4.1166.22</allowedValuesetOids>
    </validator>
</expression>
<!-- PREGNANCY INTENTION IN NEXT YEAR START -->
drbgfc commented 11 months ago

Please review the entire file for other possible severity issues, thanks!