search

onc-healthit / reference-ccda-validator

Deployable C-CDA Validator war source code. Use this repository to build and deploy a validator on your local environment.
BSD 2-Clause "Simplified" License
36 stars 37 forks source link

Null return value from advice does not match primitive return type for: public abstract boolean #30

Closed usmanq8 closed 6 years ago

usmanq8 commented 6 years ago

I am blank as to why i got his error: i am using "170.315_b1_toc_amb_ccd_r21_sample1_v12.xml" provided for certification.

03-08-2018 17:07:38 [ERROR] ReferenceCCDAValidationService.processValidateCCDAException:104 - The service has encountered the following error: org.springframework.aop.AopInvocationException: Null return value from advice does not match primitive return type for: public abstract boolean org.sitenv.vocabularies.validation.repositories.CodeRepository.codeIsActive(java.lang.String,java.util.Set) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:221) at com.sun.proxy.$Proxy57.codeIsActive(Unknown Source) at org.sitenv.vocabularies.validation.validators.nodetypes.CodeSystemCodeValidator.validateNode(CodeSystemCodeValidator.java:74) at org.sitenv.vocabularies.validation.services.VocabularyValidationService.validate(VocabularyValidationService.java:113) at org.sitenv.vocabularies.validation.services.VocabularyValidationService.validate(VocabularyValidationService.java:75) at org.sitenv.referenceccda.validators.vocabulary.VocabularyCCDAValidator.doValidation(VocabularyCCDAValidator.java:59) at org.sitenv.referenceccda.validators.vocabulary.VocabularyCCDAValidator.validateFileImplementation(VocabularyCCDAValidator.java:49) at org.sitenv.referenceccda.validators.vocabulary.VocabularyCCDAValidator.validateFile(VocabularyCCDAValidator.java:39) at org.sitenv.referenceccda.services.ReferenceCCDAValidationService.doVocabularyValidation(ReferenceCCDAValidationService.java:191) at org.sitenv.referenceccda.services.ReferenceCCDAValidationService.runValidators(ReferenceCCDAValidationService.java:131) at org.sitenv.referenceccda.services.ReferenceCCDAValidationService.validateCCDAImplementation(ReferenceCCDAValidationService.java:72) at org.sitenv.referenceccda.services.ReferenceCCDAValidationService.validateCCDA(ReferenceCCDAValidationService.java:58)

usmanq8 commented 6 years ago

resulterror this is what i get on local Tomcat after running the file

drbgfc commented 6 years ago

Are you using this 1.0.33 (latest) version of the WAR? https://github.com/siteadmin/reference-ccda-validator/releases/tag/1.0.33

I noticed the log says 03-08-2018 17:07:38 [ERROR] - are you sure that is the correct log or did you experience this issue that long ago?

And do you know what version of LOINC you are using?

usmanq8 commented 6 years ago

POM points to 1.0.32 version & code validator api 1.0.14. WAR and source code both gives same error. I can take latest and verify it. Abount LONIC i am not sure but the code it gave error upon was inactive and having 3 rows in DB.

usmanq8 commented 6 years ago

Thanks. Issue got resolved after taking latest source code.

jasoncmedent commented 6 years ago

I'm actually still having this error, and I'm using the 1.0.33 WAR. It also happens with the test tool validator as well. I've attached the (de-identified) referral note I'm testing with.

Thank You Jason Countryman

This message and any attachments may contain information that is protected by law as privileged and confidential, and is transmitted for the sole use of the intended recipient(s). If you are not the intended recipient, you are hereby notified that any use, dissemination, copying or retention of this e-mail or the information contained herein is strictly prohibited. If you received this e-mail in error, please immediately notify the sender by e-mail, and permanently delete this e-mail.

From: "usmanq8" notifications@github.com To: "siteadmin/reference-ccda-validator" reference-ccda-validator@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Sent: Tuesday, August 7, 2018 3:14:24 AM Subject: Re: [siteadmin/reference-ccda-validator] Null return value from advice does not match primitive return type for: public abstract boolean (#30)

Closed [ https://github.com/siteadmin/reference-ccda-validator/issues/30 | #30 ] .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, [ https://github.com/siteadmin/reference-ccda-validator/issues/30#event-1774532519 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AZrgN84lYJdXQmUUBWdCaoTXTRN_AL79ks5uOT5PgaJpZM4Vt4B0 | mute the thread ] .

<?xml version="1.0" encoding="utf-8" ?> <?xml-stylesheet type="text/xsl" href="cda.xsl" ?>

Referral Note 123 Anystreet Rd. Auburn NY 13021-3277 US Test J Validate V235 Medent Family Medicine 15 Hulbert St Auburn NY 13021-3481 US Test Care Team Member 4900 Broad RD Pob Ste 2H Syracuse NY 13215 US Weinstein, Howard, MD - Obstetrics & Gynecology
Problems
Date Description Provider Status
Onset: 03/02/2011 Benign essential hypertension Tina Tomasso, M.D. Active
Onset: 01/06/2016 Essential hypertension Tina Tomasso, M.D. Active
Onset: 02/28/2014 Mixed hyperlipidemia Tina Tomasso, M.D. Active
Onset: 04/16/2012 Overweight Tina Tomasso, M.D. Active
Onset: 04/20/2012 Vitamin D deficiency Tina Tomasso, M.D. Active
Onset: 03/01/2014 Iron deficiency anemia Tina Tomasso, M.D. Active
Onset: 03/02/2011 Asthma without status asthmaticus Tina Tomasso, M.D. Active
Onset: 03/02/2011 Attention deficit hyperactivity disorder, predominantly inattentive type Tina Tomasso, M.D. Active
Onset: 01/18/2012 Migraine without aura, not refractory Tina Tomasso, M.D. Active
Onset: 04/17/2012 Mild recurrent major depression Tina Tomasso, M.D. Active
Onset: 04/17/2012 Dietary management surveillance Tina Tomasso, M.D. Active
Onset: 05/29/2014 Obesity Tina Tomasso, M.D. Active
Onset: 01/06/2016 Generalized anxiety disorder Tina Tomasso, M.D. Active
Onset: 01/23/2018 Panic disorder with agoraphobia Tina Tomasso, M.D. Active
Allergies, Adverse Reactions, Alerts
Date Description Reaction Status Severity Comments
05/01/2001 Sulfa Active Rash, Fever
01/23/2018 Diovan HCT Active dizzy; lightheaded
Medications
drbgfc commented 6 years ago

I will look into this - thanks!

drbgfc commented 6 years ago

Update: I have reproduced this on my local machine. It is related to LOINC, but not related to the version, so unrelated to the fix for this month which allows for the latest LOINC version in addition to older ones. That fix did solve the issue for the original poster of this bug. I have never seen the issue happen in any other file but the one you sent. I will keep isolating the issue and resolve. Thanks for the patience.

jasoncmedent commented 6 years ago

Thank you, Dan, for your time on this. I appreciate it.

Thank You Jason Countryman

This message and any attachments may contain information that is protected by law as privileged and confidential, and is transmitted for the sole use of the intended recipient(s). If you are not the intended recipient, you are hereby notified that any use, dissemination, copying or retention of this e-mail or the information contained herein is strictly prohibited. If you received this e-mail in error, please immediately notify the sender by e-mail, and permanently delete this e-mail.

From: "Dan Brown" notifications@github.com To: "siteadmin" reference-ccda-validator@noreply.github.com Cc: "jasoncmedent" jasonc@medent.com, "Comment" comment@noreply.github.com Sent: Wednesday, August 8, 2018 6:31:11 PM Subject: Re: [siteadmin/reference-ccda-validator] Null return value from advice does not match primitive return type for: public abstract boolean (#30)

Update: I have reproduced this on my local machine. It is related to LOINC, but not related to the version, so unrelated to the fix for this month which allows for the latest LOINC version in addition to older ones. I have never seen the issue happen in any other file but the one you sent. I will keep isolating the issue and resolve. Thanks for the patience.

— You are receiving this because you commented. Reply to this email directly, [ https://github.com/siteadmin/reference-ccda-validator/issues/30#issuecomment-411574325 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AZrgN4o79NYAuyjU2Us0QZXXt8OLmha5ks5uO2avgaJpZM4Vt4B0 | mute the thread ] .

drbgfc commented 6 years ago

@jasoncmedent - do you ever build the ref val yourself? If so, this appears to resolve the issue: Changing the query on line 37 in /codevalidator-api/src/main/java/org/sitenv/vocabularies/validation/repositories/CodeRepository.java to

@Query("SELECT c.active FROM Code c WHERE c.code = :code and c.codeSystem in (:codesystems)")

Plenty of testing will need to be done to verify it doesn't cause any other issues or miss any results. For the file you sent, it takes a long time, but typical files seem to perform about the same.

jasoncmedent commented 6 years ago

I've actually never been able to get a working ref val build on my own, even without modifications to the code.

Thank You Jason Countryman

This message and any attachments may contain information that is protected by law as privileged and confidential, and is transmitted for the sole use of the intended recipient(s). If you are not the intended recipient, you are hereby notified that any use, dissemination, copying or retention of this e-mail or the information contained herein is strictly prohibited. If you received this e-mail in error, please immediately notify the sender by e-mail, and permanently delete this e-mail.

From: "Dan Brown" notifications@github.com To: "siteadmin" reference-ccda-validator@noreply.github.com Cc: "jasoncmedent" jasonc@medent.com, "Mention" mention@noreply.github.com Sent: Friday, August 10, 2018 2:02:35 PM Subject: Re: [siteadmin/reference-ccda-validator] Null return value from advice does not match primitive return type for: public abstract boolean (#30)

[ https://github.com/jasoncmedent | @jasoncmedent ] - do you ever build the ref val yourself? If so, this appears to resolve the issue: Changing the query on line 37 in /codevalidator-api/src/main/java/org/sitenv/vocabularies/validation/repositories/CodeRepository.java to

@Query("SELECT c.active FROM Code c WHERE c.code = :code and c.codeSystem in (:codesystems)")

Plenty of testing will need to be done to verify it doesn't cause any other issues or miss any results. For the file you sent, it takes a long time, but typical files seem to perform about the same.

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/siteadmin/reference-ccda-validator/issues/30#issuecomment-412160403 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AZrgN_lacmeSF-utrW8q93IlTkbA82WEks5uPcq7gaJpZM4Vt4B0 | mute the thread ] .

drbgfc commented 6 years ago

Sorry about that. Here are the results, maybe that will help somewhat for now... jasonC-results.txt

Or maybe you can tell me if the results are at least as expected. Thanks.

drbgfc commented 6 years ago

Hi Jason, This issue has been resolved in https://github.com/siteadmin/reference-ccda-validator/releases/tag/1.0.34 /SITE 3.1.18 which was released yesterday. Closing the issue. It does however take a VERY LONG time to validate since it is a large file. By that I mean in the range of 15-20 minutes. Apologies for that, but, just so you know it is not stuck in a loop but actually chugging along. I'm guessing an IG only test would be dramitically faster than this (IG + Vocab).

Thanks, Dan

jasoncmedent commented 6 years ago

Thanks, Dan.

Yeah, this file is definitely a torture test. Thanks for looking into this.

Thank You Jason Countryman

This message and any attachments may contain information that is protected by law as privileged and confidential, and is transmitted for the sole use of the intended recipient(s). If you are not the intended recipient, you are hereby notified that any use, dissemination, copying or retention of this e-mail or the information contained herein is strictly prohibited. If you received this e-mail in error, please immediately notify the sender by e-mail, and permanently delete this e-mail.

From: "Dan Brown" notifications@github.com To: "siteadmin" reference-ccda-validator@noreply.github.com Cc: "jasoncmedent" jasonc@medent.com, "Mention" mention@noreply.github.com Sent: Tuesday, August 28, 2018 4:18:49 PM Subject: Re: [siteadmin/reference-ccda-validator] Null return value from advice does not match primitive return type for: public abstract boolean (#30)

Closed [ https://github.com/siteadmin/reference-ccda-validator/issues/30 | #30 ] .

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/siteadmin/reference-ccda-validator/issues/30#event-1814059140 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AZrgN_jUGBlXdQ3XtDSxJquGOMLAopYZks5uVaWpgaJpZM4Vt4B0 | mute the thread ] .

drbgfc commented 6 years ago

Hah indeed - np

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.
Medication Date Status Form Strength Qnty SIG Indications Ordering Provider
Bystolic 02/06/2018 Active Tablets 5mg 30tabs 1 by mouth every day I10 Tina Tomasso, M.D.
Bupropion HCL ER (XL) 01/23/2018 Active Tablets ER 24HR 300mg 30tabs 1 by mouth every day F33.0 Tina Tomasso, M.D.
Ciprofloxacin HCL 03/12/2018 - 03/19/2018 Hx Solution 0.3% 5ml 1 drop to each affected eye twice a day for 3 to 7 days H10.9 Tina Tomasso, M.D.
Bystolic 01/23/2018 - 02/06/2018 Hx Tablets 5mg 14tabs 1 by mouth every day I10 Tina Tomasso, M.D.
Tamiflu 03/28/2017 - 04/07/2017 Hx Capsules