earth2travis
commented
4 months ago Notes from Call With Dekan
Underscores are a naming convention for private variables.
Base URI should be the metadata.
Being able to input the URI when you Write Contract is good for testing. But you will probably want to specify it in your production contracts. It is typically restricted to a market contract. Or a server that has the private key and returns the URI. He used base 64 encoded metadata to avoid having to store the data. Browsers understand the encoded file.
If you got to Read Contract and input your token IDs into the tokenURI function:
- 0: "ipfs://QmYNsRQWtiC37rkf66gxPSvu4FRtFWp2kgMU9z2yi1HfPiipfs://QmYNsRQWtiC37rkf66gxPSvu4FRtFWp2kgMU9z2yi1HfPi"
- 1: "ipfs://QmYNsRQWtiC37rkf66gxPSvu4FRtFWp2kgMU9z2yi1HfPiipfs://QmSouB7L7mVsonRtp168ybpFkQThwmtZLeanjJ6uynY1bs"
You can see that it is concatenating two IPFS addresses. The second address is the one you are putting in when you Write Contract. The first one was when you input the metadata (shall-we.json) the second one was when you input the image (shall-we.png).
Need to figure out how to only return one address.
In the function tokenURI "super" calls the tokenURI function from the parent contracts. This overrides and integrates the functionality from ERC721.sol and ERC721URIStorage.sol.
In the ERC721.sol you import this is the tokenURI function:
/**
* @dev See {IERC721Metadata-tokenURI}.
*/
function tokenURI(uint256 tokenId) public view virtual returns (string memory) {
_requireOwned(tokenId);
string memory baseURI = _baseURI();
return bytes(baseURI).length > 0 ? string.concat(baseURI, tokenId.toString()) : "";
}Maybe remove token URI storage from SafeMint. Remove the "super" from tokenURI
change:
function tokenURI(uint256 tokenId)
public
view
override(ERC721, ERC721URIStorage)
returns (string memory)
{
return super.tokenURI(tokenId);
}to:
function tokenURI(uint256 tokenId)
public
view
override(ERC721, ERC721URIStorage)
returns (string memory)
{
require(ownerOf(tokenId)!=address(0), "No Owner");
return _baseURI();
}
Deployed
TestWe.solERC-721 contract andTestWe.t.solto Base Sepolia in https://github.com/onchain-warfare/contracts/issues/1Used the the Solidity Wizard to create a starter template to work from: https://github.com/onchain-warfare/contracts/issues/1#issuecomment-2189296844
Made a few minor changes to the starter template: https://github.com/onchain-warfare/contracts/issues/1#issuecomment-2189296879
Got the tests passing and the contract deployed and verified: https://sepolia.basescan.org/address/0x5324735Aa67FaE868C90795CBbAD9F78700664dD
Minted two test NFTs:
For the first one I used the metadata in the uri (string):
ipfs://QmYNsRQWtiC37rkf66gxPSvu4FRtFWp2kgMU9z2yi1HfPi (
shall-we.json)For the second on I used the image in the uri (string):
ipfs://QmSouB7L7mVsonRtp168ybpFkQThwmtZLeanjJ6uynY1bs (
shall-we.png)Of course the biggest issue is the images are not showing.
But here is a list of other things I would like to figure out:
Issues
safeMint?)#0(Should probably start with#1.)safeMint