search

onchain / paper-wallet-spender

Create transactions for multiple currencies from private keys.
0 stars 4 forks source link

Finish the Blockchain.info Provider [$50] #1

Closed 9876691 closed 6 years ago

9876691 commented 6 years ago

The Blockchain.info provider is located here https://github.com/onchain/paper-wallet-spender/blob/master/src/onchain/providers/blockchaininfo_provider.cr

The push_tx method needs to be implemented. The current implementation is not correct. You can test it by sending any valid bitcoin transaction and see what message you get back from blockchain.info.

Also create a new method

get_all_balances(coin : CoinType, address : Array(String), set_rate = true)

This should return the same results as get_balance but for each address.

Blockchain.info provider a multi address call that let's you get balances for a bunch of addresses in one go. See documentation here. https://www.blockchain.com/en/api/blockchain_api

https://blockchain.info/multiaddr?active=$address|$address

Both the push_tx and get_all_balances methods need a test added to the blockchaininfo_spec.cr

There's a bounty for this issue https://www.bountysource.com/issues/60938673-finish-the-blockchain-info-provider

ghost commented 6 years ago

Hi Ian, I just wanted to let you know that both the push_tx and get_all_balances methods are complete and I will make a pull request once I have completed the test for each.

9876691 commented 6 years ago

Great thanks.

ghost commented 6 years ago

I have made a pulll request for Blockchain.info Provider

9876691 commented 6 years ago

@ATJohnson solved this. Thanks.