search

oncode / handorgel

Accessible W3C conform accordion written in ES6.
https://oncode.github.io/handorgel/
MIT License
261 stars 25 forks source link

`aria-multiselectable` is invalid in this context #37

Open JacobDB opened 3 months ago

JacobDB commented 3 months ago

If you run a Lighthouse report on your own demo, you'll get this notice:

*`[aria-]` attributes do not match their roles**

Each ARIA role supports a specific subset of aria-* attributes. Mismatching these invalidates the aria-*attributes. Learn how to match ARIA attributes to their roles.

Failing Elements

Lorem ipsum (autofocused) Lorem ipsum (default opened) Lorem ipsum dolor sit a… <div class="handorgel default" id="handorgel1" aria-multiselectable="true">

Looking in to aria-multiselectable, I see that it's only valid on elements with these roles: grid, listbox, tablist, or tree. Additionally, the W3's accordion example doesn't include aria-multiselectable.

Can you please remove this attribute? From everything I've found, it seems unnecessary in this context, and one of my clients is complaining about this warning in Lighthouse. I know I could just disable multiselection, but that's not really the problem, the aria-multiselectable attribute appears to be unneeded either way.