search

oncode / handorgel

Accessible W3C conform accordion written in ES6.
https://oncode.github.io/handorgel/
MIT License
261 stars 25 forks source link

Uncaught ReferenceError: Handorgel is not defined #6

Closed jeremy-wgd closed 6 years ago

jeremy-wgd commented 6 years ago

Hi there

I seem to have done everything to make it work, but I am getting the above JS error on this page:

http://rimesweb.staging.wpengine.com/privacy-confidentiality-2/

Ta for any help!

oncode commented 6 years ago

Hi jeremy,

I've noticed that you include the UMD build of the library via script tag. Because the package name is defined as handorgel (lowercase), the lib is exported to window.handorgel.

In the README it's new Handorgel, but it should be written new handorgel or new window.handorgel, then it should work properly on your site. Usually, I use webpack and import the lib with import Handorgel from 'handorgel, then it would be new Handorgel.

Sorry for any inconveniences. I fixed the README to avoid confusion for other people using the UMD build. Thanks for stating the issue!

jeremy-wgd commented 6 years ago

Hi Manuel

Thanks for your quick reply, that has fixed the problem. Also, there are a couple of other minor issues in the documentation I discovered...

In the initialisation JS (which I copied/pasted for testing), there seems to be a comma missing. Also the querySelector references ".accordon", whereas if you copy the sample markup (as I did), the class is called " handorgel":

[image: Inline images 4] [image: Inline images 3]

Thanks again for your help!

Jeremy

On 30 October 2017 at 12:19, Manuel Sommerhalder notifications@github.com wrote:

Hi jeremy,

I've noticed that you include the UMD build of the library via script tag. Because the package name is defined as handorgel (lowercase), the lib is exported to window.handorgel.

In the README it's new Handorgel, but it should be written new handorgel or new window.handorgel, then it should work properly on your site. Usually, I use webpack and import the lib with import Handorgel from 'handorgel, then it would be new Handorgel.

Sorry for any inconveniences. I fixed the README to avoid confusion for other people using the UMD build. Thanks for stating the issue!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oncode/handorgel/issues/6#issuecomment-340427676, or mute the thread https://github.com/notifications/unsubscribe-auth/AeAvyuaGRgrxue2obVRqC8Zaa1hjle6sks5sxb7CgaJpZM4QLD9O .

--

Kind regards,

Jeremy Wray

WordPress Developer

www.wholegraindigital.com

+44 (0) 7928639551

@eatwholegrain https://twitter.com/eatwholegrain

oncode commented 6 years ago

Thank you, I've fixed the README file. Just write if you find another issue.

jeremy-wgd commented 6 years ago

Great thanks Manuel!

On 30 October 2017 at 14:24, Manuel Sommerhalder notifications@github.com wrote:

Closed #6 https://github.com/oncode/handorgel/issues/6.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oncode/handorgel/issues/6#event-1316770935, or mute the thread https://github.com/notifications/unsubscribe-auth/AeAvyqI_8uh4y5BeK8olxx6RZBfLuYLXks5sxdwQgaJpZM4QLD9O .

--

Kind regards,

Jeremy Wray

WordPress Developer

www.wholegraindigital.com

+44 (0) 7928639551

@eatwholegrain https://twitter.com/eatwholegrain