search

oncojs / oncogrid

Javascript library for visualizing OncoGrids and related tracks
Apache License 2.0
26 stars 8 forks source link

Don't directly use IDs as part of selectors (or don't use class selectors) #36

Open cheapsteak opened 7 years ago

cheapsteak commented 7 years ago

When IDs contain characters that are not valid selectors (e.g. spaces, slash), zoom breaks

This should be solvable if the id is put on a data-id field, so this should work [data-id="id/2#$#@$"]

https://github.com/NCI-GDC/portal-ui/pull/1946#pullrequestreview-50656832

Jephuff commented 7 years ago

I think it is reasonable that the id is used in selectors. Other values can be used for display purposes. For now it can be done in templates(https://github.com/NCI-GDC/portal-ui/pull/1965) and if https://github.com/oncojs/oncogrid/issues/20 is done, it can be done in the handlers.