oncokb / oncokb-annotator

Annotates variants in MAF with OncoKB annotation.
GNU Affero General Public License v3.0
121 stars 59 forks source link

Parallel #121

Closed HershGupta404 closed 2 years ago

HershGupta404 commented 3 years ago

This adds an option to run code in parallel on multiple processes providing speedup. The number of procs can be specified from CLI and defaults to 4.

Future Progress/Issues:

HershGupta404 commented 3 years ago

@jjgao @zhx828 Let me know if you need anything else or more comments on the changes I made

zhx828 commented 3 years ago

@jjgao @zhx828 Let me know if you need anything else or more comments on the changes I made

Thank you for submitting the pull request! I will take a look this week and get back to you.

zhx828 commented 3 years ago

@HershGupta404 thanks again for the effort. Here are few questions before taking a more detailed look at the pr

HershGupta404 commented 3 years ago

@zhx828 I think the parallel files should be deleted from commits 2-3. I updated the test file to work with the updated parallel code in commit 2. I can try to remove the parallel code from the commit history.

zhx828 commented 3 years ago

@HershGupta404 will you work on this soon? Do you want me take over whatever is left?

zhx828 commented 2 years ago

Gonna close this ticket since I haven't heard back from the user. Will reopen if situation changes.