A user reported that comparison with the IBSI reference standard failed when using a configuration file. mirp can be configured through keyword arguments and the settings xml file. The tests that assert compliance with the IBSI reference standard are based on direct specification of the settings object.
Keywords and xml-based arguments are both used to initialise a settings object. However, we currently do not test whether keyword arguments and arguments from the settings xml file yield the same settings objects, and that these setting objects then contain the expected values.
[x] Test that specifying only required configuration parameters leads to the same settings object for keyword, xml, as well as direct specification.
[x] Parse xml tags to keyword arguments. This prevents potential mismatches in default argument values. If a tag is not set, the keyword argument is not added. To do so we need to:
[x] Specify for each tag its argument name (if different), its type, and a non-default alternative that is used to test against.
[x] Use the above specification to initialise a dict, or a specific class that contains this information.
[x] Use the dict to parse tags to keyword arguments (itself a dict contain the argument name as key and its value as value).
[x] Test that non-default arguments lead to the same settings object for keyword, xml, as well as direct specification.
[x] Use the above dictionary to set non-default values and test them.
A user reported that comparison with the IBSI reference standard failed when using a configuration file.
mirp
can be configured through keyword arguments and the settingsxml
file. The tests that assert compliance with the IBSI reference standard are based on direct specification of the settings object.Keywords and
xml
-based arguments are both used to initialise a settings object. However, we currently do not test whether keyword arguments and arguments from the settingsxml
file yield the same settings objects, and that these setting objects then contain the expected values.Test that specifying only required configuration parameters leads to the same settings object for keyword,xml
, as well as direct specification.xml
tags to keyword arguments. This prevents potential mismatches in default argument values. If a tag is not set, the keyword argument is not added. To do so we need to:dict
, or a specific class that contains this information.dict
to parse tags to keyword arguments (itself adict
contain the argument name as key and its value as value).xml
, as well as direct specification.