ondat / terraform-eksblueprints-ondat-addon

Terraform Amazon EKS Blueprints addon to enrich stateful storage in Kubernetes.
https://www.ondat.io/blog/ondat-is-now-available-via-amazon-eks-blueprints
Apache License 2.0
4 stars 2 forks source link

Module doesn't work with Terraform 1.3.0 #11

Open mbenson opened 2 years ago

mbenson commented 2 years ago

Describe the bug Modules using optional object attributes via the experiments attribute of the terraform block are no longer valid with this latest release of the tool.

To Reproduce Steps to reproduce the behavior:

https://github.com/mbenson/terraform-aws-eks-blueprints/tree/tf-130 is a branch containing my cut of updates to make the EKS blueprints project 1.3.0-compatible. Using e.g. examples/complete-kubernetes-addons you will find that terraform init returns a number of Error: Experiment has concluded messages, the first such pertaining to terraform/modules/eks_blueprints_kubernetes_addons.ondat/locals.tf.

Expected behavior I would expect terraform init to succeed, at least, for our purposes here, with regard to this module.

Desktop (please complete the following information):

mbenson commented 2 years ago

I was in the process of submitting a PR for this issue, but there is a chicken-and-egg situation here that I think bears further discussion:

The changes required for this module are minimal and are represented at https://github.com/mbenson/terraform-eksblueprints-ondat-addon/tree/tf-130 . However, this module depends on https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/modules/kubernetes-addons/helm-addon which is also subject to the TF 1.3.0 incompatibility (https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/988). But because https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/modules/kubernetes-addons/ depends on this module neither entity can be fully fixed without the other. For my own testing I was able to confirm these changes worked by setting the module dependencies up with local filesystem source declarations, using my branch of the blueprints module at https://github.com/mbenson/terraform-aws-eks-blueprints/tree/tf-130 .

It may be possible to fix https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/modules/kubernetes-addons/helm-addon first, then this one, then the remainder of https://github.com/aws-ia/terraform-aws-eks-blueprints/ (which as far as I can tell amounts to its modules/launch-templates but that's immaterial here). I am hoping the developers/community have some experience with coordinating changes between these modules.