ondra-novak / mmbot

Market Making trading bot for cryptomarkets
MIT License
219 stars 57 forks source link

TP requested #14

Open Pat2018-1 opened 4 years ago

Pat2018-1 commented 4 years ago

Hi,

Thanks for your hard work mate, MMBOT is working greate. But is there any possibillity u add tp? Sometimes i have more then 200% profit and sometimes i lose it all. Thanks!

ondra-novak commented 4 years ago

Hi Thank you for the idea. However currently i don't have an idea how to achieve TP in continuously trading strategy. You can anytime to stop trading, close the position and reset the strategy. But it would be hard to define, when to activate such a trigger

Would it be a kind of new strategy?

Several strategies (such a Linear and Stairs) have stoploss feature, - however even if it was improved over time, it is not 100% protection.

Stairs - reaching the last step, it can add a stoploss (as alert) as next step in the same direction Linear - reaching maximum position, it puts LIMIT to close position on the top of the orderbook and updates it every minute.

you can suggest any idea how to implement TP - i.e. how to trigger to stop of the trading in a profit.

Pat2018-1 commented 4 years ago

Hi,

Thanks for your reply:)

Yeah i know what u mean but if you can implament a stoploss u can make a TP, i am not a developer but in my idea its a reverse of a stoploss.

i have a good strategy but its in python... maybe we can discuss this by mail or telegram?

Thanks again for your hard work mate.

Regards, Patrick

ondra-novak commented 4 years ago

Problem is, that stoploss is activated, when the price or the trading situation reaches an edge condition as described above. Profit is not an edge condition. Such an edge condition must be defined. An other issue is to define the profit. For someone it would be to maximize fiat, for others it would be to maximize assets.

Pat2018-1 commented 4 years ago

Oke, understand your point. Could you maybe implament an strategy as this? https://github.com/FrancoASola/BitmexMarketMakerBot