Closed xinyubot closed 1 year ago
Hey, thanks for the PR. The checks are failing I believe the reason is that go.mod
file defines go version 1.12, try changing that to 1.18 a running go mod tidy
again.
Hey, thanks for the PR. The checks are failing I believe the reason is that
go.mod
file defines go version 1.12, try changing that to 1.18 a runninggo mod tidy
again.
Thanks for replying. I've changed go version to 1.18; however the checks are still failing. It seems that we have two checks for both go 1.17 and 1.18, and the one for 1.17 has the following error message: go mod tidy: go.mod file indicates go 1.18, but maximum supported version is 1.17
😅
If you want to support the two latest major releases of go, I've changed go.mod
go version to 1.17 since by doing so it passes the checks.
Output of current version of go-callvis:
It panicked because some historical version of dependencies do not support go 1.18 generics type parameters. I simply updated the dependencies and re-built from source, and it worked well.
Go version remains as go 1.12, so it won't affect developers without go 1.18 installed locally to build from source.