search

ondrajz / go-callvis

Visualize call graph of a Go program using Graphviz
https://ofabry.github.io/go-callvis
MIT License
5.94k stars 409 forks source link

Passthru of graphviz node shape,style #84

Closed Russtopia closed 3 years ago

Russtopia commented 3 years ago

Addition of -nodeshape and -nodestyle to allow some customization of output visuals

Russtopia commented 3 years ago

I kind of forgot about this PR. Any objection to it? It just adds ability to let the user style the graph nodes.

Thanks, -Russ

suntong commented 3 years ago

Bump

Russtopia commented 3 years ago

Bump

Hmm, seems @ofabry is not giving attention lately to anything other than private repos according to his github activity ... if you want this feature, go grab my fork over at https://github.com/Russtopia/go-callvis/tree/node-styles for now.

Hopefully someday he'll be back to merge here :)

ondrajz commented 3 years ago

Hey @Russtopia thanks for the PR and sorry for the delay. Work and life keeping me busy..

Could you please update the PR and pass the parameters via graph's Options field similarly to minlen. The dot template should not really have access to the raw flags anyway.

Russtopia commented 3 years ago

Hey @Russtopia thanks for the PR and sorry for the delay. Work and life keeping me busy..

Could you please update the PR and pass the parameters via graph's Options field similarly to minlen. The dot template should not really have access to the raw flags anyway.

Understood :) I've updated it to use the templating as minlen does -- seems to work locally. Hope that's more in style with what you wanted!

Cheers, -R.