search

ondrakoupil / csob

PHP client for ČSOB payment gateway eAPI
MIT License
44 stars 18 forks source link

Keys as file path - why? #53

Open jspetrak opened 1 year ago

jspetrak commented 1 year ago

Hello, Is there a reason why the keys must be provided as file paths? We are obtaining the keys from AWS S3 so I now workaround using tmp file but would like to provide a PR to be able to provide the key values directly.

ondrakoupil commented 1 year ago

Hi, I think there is no reason for that, it was just the most common way how the key was saved. If you make a PR that enables both ways to provide the key, that will be great.

jspetrak commented 1 year ago

@ondrakoupil Thanks for the reaction. I have proposed the change in pr #54. Feel free to comment if you like that or prefer different approach. It is also a BC, but that could be resolved by the union type string|KeyProvider.