search

ondras / my-mind

Online Mindmapping Software
https://my-mind.github.io
MIT License
3.3k stars 652 forks source link

Embedded Video Links Wont Close #147

Open mikekalas opened 3 years ago

mikekalas commented 3 years ago

Hello Friends,

I noticed a problem with links for embedded videos such as one like this:

Why food prices are rising in the United States - CNBC - VIDEO

<>

If I were to save the link with the embed code the video is displayed in the mind map. But the video being displayed has no x button to close the window. Nor is there an option to close the window by right clicking. And then once you click on the video in the mind map, the video window sticks to the cursor, follows the cursor around the screen, and then you can't click on anything else.

If there's one person who can find a way to break something its me. : ) Hope at least I can help reveal a problem that can potentially be fixed.

Cheers, and Good Luck!

Mike

ondras commented 3 years ago

Hi @mikekalas,

thanks for the bugreport. I am somewhat puzzled by your description; would you be so kind and provide a sample Mind Map that showcases the issue? Or at least some step-by-step instructions to replicate the problematic behavior.

mikekalas commented 3 years ago

Hmm. now I tried it again and it doesn't seem to be happening and everything is working okay. But I swear I wasn't hallucinating and previously when I clicked on a video it would be stuck to the cursor and would move all around the screen not letting me unclick. Could be a glitch on my end, i'm usually the xfactor.

I was using Freemind and I copied a section of my mind map from Freemind and pasted it into Mymind. I noticed the problem occurred when pasting a hyperlink that has an embed code for a video as opposed to a traditional URL to a webpage. And it happened in the initial editing environment before saving the mindmap.

So the steps would be to start a mindmap in Freemind, make a new node, then hit ctrl+k to turn that node into a hyperlink, then paste an embed code as opposed to a URL, then copy and paste the node hyperlinked with embed code into Mymind is how I initially encountered the problem.

But now I did it again and and the video displays properly without being glued to the cursor. Weird. If it happens again I'll let you know. Otherwise sorry to bother if its just me.

ondras commented 3 years ago

Weird. If it happens again I'll let you know. Otherwise sorry to bother if its just me.

No problem. The steps you describe seem complex enough so it is totally possible that something gets screwed.

Generally speaking, iframe-based content is heavily restricted in browsers when the iframe's domain does not match the URL in addressbar. This is an inherent security-based limitation that cannot be really worked around. So if you run into issues regarding such foreign iframe, there is very little we can do. Interaction with this kind of content might be basically forbidden.