search

ondras / my-mind

Online Mindmapping Software
https://my-mind.github.io
MIT License
3.29k stars 651 forks source link

Google analytics and other javascript files #160

Closed pozzo-balbi closed 1 year ago

pozzo-balbi commented 2 years ago

Hi, I have my-mind running on my server and I see noscript blocking google analytics and other javascript files being loaded from different domains.

Now my problem is that I am not using google analytics, so how is this project using google analytics?

This means that my website is providing data from my visitors to third party and be it only the IP address of my visitors. Now the problem with that is that since it is not my google analytics, I don't have a data processing contract with google regarding those IP addresses (which qualify as personal data under the GDPR).

Transmitting personal data to third parties without consent is illegal under the GDPR. Having a third party receive personal data without a data processing agreement is illegal under the GDPR.

GDPR = https://en.wikipedia.org/wiki/General_Data_Protection_Regulation

And if it is possible to load javascript files locally, that would also help avoid leaking of personal data.

ondras commented 2 years ago

Hi @pozzo-balbi,

thanks for your comment. Your observation is correct; as you can see, the source code includes the Google Tag Manager. This is simply because I wanted to measure traffic for the publicly hosted site at https://my-mind.github.io/.

I assume that the correct solution here would be to remove the GTM code from the code at https://github.com/ondras/my-mind/ and add it specifically for the fork at https://github.com/my-mind/my-mind.github.io.

I am, unfortunately, somewhat out of time right now, leaving for a 3-week vacation in two days. If you wish, feel free to submit this change via PR. I would be able to do that myself once I return, probably in September.