ondras / my-mind

Online Mindmapping Software
https://my-mind.github.io
MIT License
3.29k stars 651 forks source link

Add Dockerfile that will allow direct server saving #167

Closed anothervictimofsurvivalinstinct closed 1 year ago

anothervictimofsurvivalinstinct commented 1 year ago

-README: Documentation on the docker image with an image showing it saved

-Dockerfile: i'm aware of the other pull request, this Dockerfile just adds the functionality for directly saving on the server it's hosted on

-Caddyfile: just the caddyfile used with the dockerfile where the user can set: savefile name, admin username and password for saving

-CaddyHashDockerfile: just a dockerfile that will create a new hash for the Caddyfile password

ondras commented 1 year ago

Hi @anothervictimofsurvivalinstinct,

thanks for the PR! I am not sure what is the best policy right here, right now. While I agree that running the app via Docker makes sense, I do not like the process of cluttering the root directory with various configuration options that are often opinionated and thus not universally useful/necessary for every user.

Perhaps a wiki-like approach would be more useful here? Like, we create a wikipage "Running via Caddy" that contains the sample configuration(s), Caddyfiles, Dockerfiles, Whatnotfiles and further instructions. The same can be, in theory, done for the second Docker-PR.

What do you think?

anothervictimofsurvivalinstinct commented 1 year ago

Hey, ya that works for me, probably would be better/easier to maintain in the long run as well.