search

ondras / rot.js

ROguelike Toolkit in JavaScript. Cool dungeon-related stuff, interactive manual, documentation, tests!
https://ondras.github.io/rot.js/hp/
BSD 3-Clause "New" or "Revised" License
2.34k stars 255 forks source link

updated to support AMD or CJS loaders #108

Closed erikyuzwa closed 7 years ago

erikyuzwa commented 7 years ago
erikyuzwa commented 7 years ago

Really wasn't sure if this was wanted, or where you'd want to put the pre and post files. Definitely open to any suggestions.

ondras commented 7 years ago

Not exactly wanted, but brings no overhead => whatever, I guess. Why not.

I would put {pre,post}.txt into a dedicated directory (umd?), as the root directory is getting too cluttered with metadata. Also, updating the rot.js (and rot.min.js) files with the improved bundle would be nice.

erikyuzwa commented 7 years ago

Not a problem at all, thus updated.

OldrichKruchna commented 7 years ago

Seems both files were moved into umd folder and also bundles were updated. Could it be reviewed again?

ondras commented 7 years ago

Sorry, I somehow completely missed this update. Thanks for the fix!

erikyuzwa commented 7 years ago

no problem at all - I had kinda forgotten about this one too. Thanks so much! :bow:

ondras commented 7 years ago

Looks like this change somehow broke the node.js build: https://github.com/ondras/rot.js/issues/124

erikyuzwa commented 7 years ago

ugh! my apologies @ondras - guess I missed that in testing when touching that makefile. Thanks for taking care of it.

ondras commented 7 years ago

I hope I already fixed that (see node build of rot.js v0.6.4) :-)