search

ondras / rot.js

ROguelike Toolkit in JavaScript. Cool dungeon-related stuff, interactive manual, documentation, tests!
https://ondras.github.io/rot.js/hp/
BSD 3-Clause "New" or "Revised" License
2.32k stars 254 forks source link

Fix canvas clear when background is transparent/translucent #214

Closed dmchurch closed 4 months ago

dmchurch commented 4 months ago

This can also be applied to e.g. Tile.draw() when clearBefore is true and tileColorize is false

ondras commented 4 months ago

Hi @dmchurch ,

thanks for the PR! Are you happy with just the .ts change, or do you want to publish the rebuilt version as well (or do you want me to do so)?

dmchurch commented 4 months ago

oh wow thanks! if you could publish the rebuilt . js it'd be nice, but not necessary - I'm using rot.js for my 7DRL entry, but I've got a monkeypatch that's working for me, but it might help for any other teams that could run into the same issue!

ondras commented 4 months ago

Good, merged & rebuilt.

dmchurch commented 4 months ago

Thank you so much! you can take a look at our current WIP if you like, at https://dmchurch.github.io/7drl-2024/ - I've been having fun taking the rot.js framework in directions it wasn't intended to go in 😂