search

ondrejklejch / MT-ComparEval

Tool for comparison and evaluation of machine translation.
Apache License 2.0
56 stars 14 forks source link

PHP7 yields compile errors in ArithmeticRecall.php and GeometricRecall.php #56

Closed jgwinnup closed 8 years ago

jgwinnup commented 8 years ago

When I use PHP7, I get the following error for ArithmeticRecall and GeometricRecall classes:

Redefinition of parameter $reference in .../ArithmeticRecall.php:15 (similar for GeometricRecall).

I changed the method signature from: 

public function addSentence( $reference, $reference, $meta ) {

to

public function addSentence( $reference, $reference1, $meta ) {

in both cases to get the application working, but I'm not sure if that's the correct thing to do.

ondrejklejch commented 8 years ago

Hello Jeremy, thank you for the information. I fixed it to:

public function addSentence( $reference, $translation, $meta ) {