ondrejvelisek / slek

Front-end for chat application written in React as a semestral project at PV247 FI MUNI

1 stars 0 forks source link

Milestone #1 #2

Open Suzii opened 6 years ago

Suzii commented 6 years ago

Status: ✔️

Below are just suggestions to consider for the next milestones.

Propbably the nicest UI I have seen. Wonderful usage of typescript, very nice and clean code. Keep up the good work in the next milestones ;)

Code suggestions

Use combineReducers()
I am not sure what your intentions are but I would merge ChatLayout and ChatPage components into one.
Channels container - wrong typing of mapStateToProps function.
Use uuid instead of Math.random()