nus-pe-script
commented
6 months ago Team's Response
It is true but we also mentioned this problem in UG. Which means the missing feature will not significantly hinder the user. Thus severity.Low would be more appropriate. (The search issue can be easily worked around by adding a space before the unique identifier.)
(handled in https://github.com/AY2324S2-CS2103T-T11-2/tp/commit/ebe93a45acb90aae8b218413b8462e0439756295 .)
Items for the Tester to Verify
:question: Issue severity
Team chose [severity.Low]
Originally [severity.Medium]
- [x] I disagree
Reason for disagreement: I still stand by my argument that adding a number suffix after a contact name should not be considered in an app specifically meant for contact management. I believe that people do not save contacts as "Alice1" or "Alice 1" in their phone, and likewise, it should not be the case for a desktop app for contact management.
Specifically in Singapore where duplicate names are very common (especially with common surnames like Tan, Lim, etc), most NUS students have encountered friends with the same name before. As such, this bug will pose to be an occasional hindrance to users (hence severity medium), rather than a minor and rare one.
Adding a disclaimer in UG does not reduce the inconvenience it brings to users, as users still have to work around this limitation and incur unnecessary effort.
The app detects duplicate contacts by the name of the contact. For example, a contact with the name "John Doe' already recorded in the database will prevent another person with the same name "John Doe" from being added as well.
To replicate:
Enter the add command "add n/John Doe p/98765432 e/johnd@example.com r/STUDENT a/311, Clementi Ave 2, #02-25 c/CS2103T t/friends t/owesMoney".
Enter another add command with the same name "John Doe" but different other parameters.
Error message displayed as shown in the above.
This will cause inconvenience to users, especially in NUS where there will be many different people of the same name. While the UG has recommended to add a prefix after the name, it will not be feasible to have numbers appended to names, as this will make searching significantly harder. Instead, it is recommended to detect duplicate users based on phone number or email instead.