Support PHP 8 and Nette 3

ondrs / Hi

Czech names and surnames greeting generator API PHP wrapper.

hi.ondraplsek.cz

MIT License

39 stars 2 forks source link

Support PHP 8 and Nette 3 #8

Open janbarasek opened 3 years ago

janbarasek commented 3 years ago

Hi!

Are you planning to add native support for PHP 8 and Nette 3 in the near future? It could be a new master version.

If you would be interested in upgrading, I can send a Pull request.

Thanks.

ondrs commented 3 years ago

All contributions are welcomed! Can you please make the upgrade BC compatible? It's a very tiny library, there is no need to have a breaking change because of PHP8 and Nette3

janbarasek commented 3 years ago

Adding data types is a BC break or not?

ondrs commented 3 years ago

Currently, it supports PHP 5.4 which is probably unnecessary. We can drop support for lower versions than PHP 7.1 so types can be added.