search

one-aalam / remix-starter-kit

Remix with brilliant bells and useful whistles
235 stars 26 forks source link

Update 'Sign In' or 'Sign Up!' aux btn title #6

Closed lucaspedroabreu closed 2 years ago

lucaspedroabreu commented 2 years ago

Hello, one-aalam!

This is my first pull request ever, so forgive me for forgetting to branch my fork before pushing the changes to my own repo before opening this pull request.

It is a really simple change. I was looking If I could implement Zod or Yup library for form validation in your template (something I would like to learn how to implement) and saw that the title of the auxiliary button didn't change with the visible content of the button.

This pull request only applies to the title of this auxiliary button of the AuthForm that changes the form from a "Sing In" to a "Sign Up". It will only have an impact on accessibility and in some tooltips methods (not with Daisy UI).

Best Regards,

Lucas

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @one-aalam on Vercel.

@one-aalam first needs to authorize it.

one-aalam commented 2 years ago

👋 Hey @lucaspedroabreu, thanks for contributing and making the component(and the starter kit) better.

👏 Congratulations on your first open-source PR :-)