one-dark / jetbrains-one-dark-theme

One Dark theme for JetBrains.
https://plugins.jetbrains.com/plugin/11938-one-dark-theme
ISC License
590 stars 65 forks source link

White background for One Dark Italic on latest build #318

Open danwilliams opened 1 year ago

danwilliams commented 1 year ago

Describe the bug After upgrading to RustRover 2023.3, and using the latest One Dark 5.9.0 (which is the one that brings 2023.3 compatibility), I have found that the One Dark Italic theme now has a white background with dark text. Meanwhile the One Dark Vivid Italic still works, so I've changed to that for now. Both of the non-italic themes still work fine.

Notably this is not the same as reported in this other, similar ticket: https://github.com/one-dark/jetbrains-one-dark-theme/issues/313

This issue only started with the latest 2023.3 with 5.9.0, and cannot be resolved with the steps in that other ticket - they have no effect.

Environment RustRover 2023.3 EAP Build #RR-233.8264.22, built on October 10, 2023

Licensed to RustRover EAP user: Dan Williams Expiration date: December 9, 2023

Runtime version: 17.0.8.1+7-b1063.1 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

apmwebdev commented 1 year ago

I'm also seeing this, but in IntelliJ. The issue seems to be that whatever version you have active when you upgrade the plugin gets the white background, while the others look normal. I initially had it on italic, which broke. I then tried uninstalling and reinstalling the plugin on vivid italic, and now both italic and vivid italic are broken.

SwishSwushPow commented 1 year ago

Solution is presented here: https://github.com/one-dark/jetbrains-one-dark-theme/issues/313#issuecomment-1741198761

T3kla commented 1 year ago

Proposed solution didn't work for me. Also, I'm experiencing this in the non italic version. Changing to italic does work tho.

SwishSwushPow commented 1 year ago

For me it helped to switch the Editor Scheme to something else, click "apply" and then change it back to "One Dark Vivid". Maybe give that a try if you haven't yet. It should be independent from the used color scheme. Just changing it to something else and then back to the desired one should help.

apmwebdev commented 1 year ago

The solution in #313 doesn't work for me either. EDIT: Yes it does.

ConnHowe commented 1 year ago

Same as you, and then the solution in https://github.com/one-dark/jetbrains-one-dark-theme/issues/313 worked for me.

apmwebdev commented 1 year ago

I got it working. Not sure what I was doing wrong before, but after trying the #313 solution a couple more times, it started working. Thanks @MrMuetze.

xsjcTony commented 1 year ago

313 Works for me

danwilliams commented 1 year ago

@MrMuetze I mentioned #313 in my original description, as I found it, and tried it. However, it hasn't resolved the issue for me. I tried it again just now. No dice. (I.e. changing via the Editor -> Color Scheme -> Scheme box.)

@apmwebdev agreed - I had One Dark Italic active, and that broke, so now I'm on One Dark Italic Vivid. Exact same as you. Thankfully that one still works.

Edit: I removed the plugin entirely, and also removed my custom colours file, then reinstalled the plugin. It works again now. I'm not sure what was in my custom file of any importance, as it all looks okay now... So yeah, if anyone else has this issue and #313 doesn't fix it, maybe try removing the custom colours file. Dunno.

HausE13 commented 9 months ago

Had this problem after updating to version 5.10.0. Looks like Color Scheme in Editor settings is not set correctly.

Fixes mentioned in #313 still worked for me.