search

one-dark / vscode-one-dark-theme

One Dark theme for VS Code.
https://marketplace.visualstudio.com/items?itemName=mskelton.one-dark-theme
ISC License
48 stars 8 forks source link

XI Language Support #2

Closed ppav closed 5 years ago

ppav commented 5 years ago

Hello Mark! I added support "Xi" format. Is a markdown-like language

link to Marketplace

mskelton commented 5 years ago

Thanks for the pull request, but I am a bit hesitant about adding this in as I would like to get away from customizing each language in a very different way from each other. What does XI look with one dark pro without the changes you made?

ppav commented 5 years ago

Of course❗️

You can compare themes and original from the @grigoryvp.

ppav commented 5 years ago

These changes are made to the main repository

mskelton commented 5 years ago

Thanks for the screenshots. I'll be happy to merge this in, but I'm also not too keen about using the error color for normal text. I want to keep that reserved for errors if possible. Could that be changed to another color?

ppav commented 5 years ago

Oh, I do not think 🤔 This will require a few changes, and I want to keep intimacy with the original

mskelton commented 5 years ago

I can understand wanting to keep it similar to the original, but I really don't like the idea of using the error color for non-errored text.

ppav commented 5 years ago

ok, i'll do it, but it will turn out from repository