search

one-dark / vscode-one-dark-theme

One Dark theme for VS Code.
https://marketplace.visualstudio.com/items?itemName=mskelton.one-dark-theme
ISC License
50 stars 8 forks source link

Feature request #28

Closed syedsimanta03 closed 4 years ago

syedsimanta03 commented 4 years ago
  1. Normal text should be white color
  2. Comment isn't readable when italic - should be normal text or bold or user option to select
  3. Also can make the HTML look better making class id tag colorful

Image Image

mskelton commented 4 years ago

Normal text should be white color

I assume by white you mean #fff rather than the current color which is white with a touch of gray. This is intentional so it isn't overpoweringly white thus making it a bit nicer on the eyes.

Comment isn't readable when italic - should be normal text or bold or user option to select

This is kind of the whole point, making comments less prominent so the actual code stands out. The font you are using happens to have really obnoxious italics, but fonts like Operator Mono, Fira Code, Dank Mono, etc. look just fine with the italics. The screenshot in the readme uses Operator Mono which shows very readable italics.

Also can make the HTML look better making class id tag colorful

Not sure what you mean here, but differentiating colors based on the type of attribute isn't something that I believe is even possible nor would it be a good idea in my opinion.

updatedOrder can be the same color as 1st one when const updatedOrder has the main color I want when reuse this var

You might have editor.semanticHighlighting.enabled set to false. When it is set to true or configuredByTheme the editor will determine that the updatedOrder variable is a const and color it properly.

syedsimanta03 commented 4 years ago

Man, I can't easily believe this theme exists @mskelton !!! You fixed all problem. Operator Mono looks super cool here. This theme just changed my mind and uninstalled material theme. Code is more readable and easy to fix and check things.

I am a UI, graphics designer and coder. if you have any side project or want to develop more apps like this I will join & love to help you. Thanks for your hard work. You are awesome.

mskelton commented 4 years ago

Thanks @syedsimanta03! I don't have any other UI heavy things planned at the moment, but I'll keep you in mind if I do.