search

one-dark / vscode-one-dark-theme

One Dark theme for VS Code.
https://marketplace.visualstudio.com/items?itemName=mskelton.one-dark-theme
ISC License
50 stars 8 forks source link

Highlight around textboxes #4

Closed dorudumitru-hh closed 5 years ago

dorudumitru-hh commented 5 years ago

Can you please add highlight around textboxes and underline selected tabs as in your intellij version of the theme?

mskelton commented 5 years ago

I'm planning to do a complete revamp of this theme to improve the consistency between this and my JetBrains theme. One of the first things will be to improve the editor styles including what you have mentioned. Please be patient as I will get to this, but it will be a little bit due to my busy schedule right now.

Thanks for opening this issue!

mskelton commented 5 years ago

@hhquerybuilder Just to give an update on this issue. As I mentioned I am still thinking about this and working towards getting this fixed in the new theme version. I released the new theme today which does require you to uninstall the old theme and install the new theme. When you update to the latest version of the old theme it will prompt you to update to the new theme.

I haven't actually got to fixing this specific issue, but now that I have the new theme setup, I'll try to get to this next.

Thanks for your patience!

mskelton commented 5 years ago

I just pushed some commits to add the border colors you suggested. Thanks for the suggestion and for the patience waiting for this to get finished. The changes will go out in the next release (probably a couple days from now).

mskelton commented 5 years ago

@all-contributors please add @hhquerybuilder to design

allcontributors[bot] commented 5 years ago

@mskelton

I've put up a pull request to add @hhquerybuilder! :tada:

mskelton commented 5 years ago

@all-contributors please add @hhquerybuilder to design

allcontributors[bot] commented 5 years ago

@mskelton

I've put up a pull request to add @hhquerybuilder! :tada:

mskelton commented 5 years ago

Version 1.2.0 released with these changes. Once again, thanks for your patience!