one-dark / vscode-one-dark-theme

One Dark theme for VS Code.
https://marketplace.visualstudio.com/items?itemName=mskelton.one-dark-theme
ISC License
50 stars 8 forks source link

Cannot enable theme #5

Closed klippx closed 5 years ago

klippx commented 5 years ago

Describe the bug Migrating from One Dark Pro Italic to One Dark Theme, the "set theme" isn't working.

To Reproduce Steps to reproduce the behavior:

  1. Install extension
  2. Click Set Color Theme
  3. Get toast "Cannot read property 'id' of undefined

Expected behavior Take a guess :)

Screenshots Screenshot 2019-10-30 at 09 11 01

Desktop (please complete the following information):

Additional context Nope.

mskelton commented 5 years ago

Thanks for reporting this issue. I have not noticed this at all when installing the new theme, so I'm a bit puzzled by it. Could you try disabling other extensions and then installing it? Also, if you open developer tools, is there more information in the console about the error?

Thanks!

klippx commented 5 years ago

When I tried again just to reproduce the error for you, I could not. I guess a relaunch of VSCode solved the issue, whatever it was. Closing this, thanks for the rapid response! :)

mskelton commented 5 years ago

Glad that the issue is fixed!