oneHamidreza / MeowBottomNavigation

Android Meow Bottm Navigation
http://etebarian.com
1.33k stars 198 forks source link

Icons size is really small after rendering on Screen #64

Open iabduul7 opened 4 years ago

iabduul7 commented 4 years ago

I was using this library in my Java Code which worked perfectly fine after facing some problems, today I used this library in Kotlin Code, which is giving me a stranger behavior. Everything is fine just these icon sizes are really really small. How do I fix this?

107499932_3224863170958091_2754002294195441958_n

victor-mcast commented 4 years ago

This is happening to me as well in a Java project.

iabduul7 commented 4 years ago

well I think this a bug in newer version

iabduul7 commented 4 years ago

Icons are working fine in version 1.2.0 but it is the problem in newer verision @oneHamidreza please fix this issue

victor-mcast commented 4 years ago

Needs a fix definitely. Also, text needs to be supported as well below icons.

iabduul7 commented 4 years ago

yes the issue is already there give it a +1

ghysuparna commented 4 years ago

@iabduul7 how did you changed selected tab color ? I want to make tabs with different color .

iabduul7 commented 4 years ago

@iabduul7 how did you changed selected tab color ? I want to make tabs with different color .

app:mbn_selectedIconColor="#3c415e"

use this line and change color of your choice, you must use hex code of color.

ghysuparna commented 4 years ago

@iabduul7 how did you changed selected tab color ? I want to make tabs with different color .

app:mbn_selectedIconColor="#3c415e"

use this line and change color of your choice, you must use hex code of color.

i already tried with this attribute, its only changing icon color but I want to change entire tab background on selected tab as you did like white and green ,As i can see in UI on selected tab its white and rest are in green color .

iabduul7 commented 4 years ago

@iabduul7 how did you changed selected tab color ? I want to make tabs with different color .

app:mbn_selectedIconColor="#3c415e" use this line and change color of your choice, you must use hex code of color.

i already tried with this attribute, its only changing icon color but I want to change entire tab background on selected tab as you did like white and green ,As i can see in UI on selected tab its white and rest are in green color .

did you try using these properties ?

PatrickPrakash commented 4 years ago

I also have this issue. If it is a bug then tag it

iabduul7 commented 4 years ago

I also have this issue. If it is a bug then tag it

I am afraid, the person who owns the repository can only tag these issues we can just open issues. Hope @oneHamidreza would see these issues ONE DAY

ghysuparna commented 4 years ago

@iabduul7 how did you changed selected tab color ? I want to make tabs with different color .

app:mbn_selectedIconColor="#3c415e" use this line and change color of your choice, you must use hex code of color.

i already tried with this attribute, its only changing icon color but I want to change entire tab background on selected tab as you did like white and green ,As i can see in UI on selected tab its white and rest are in green color .

did you try using these properties ?

Yes I tried with this but only icon color is changing.

iabduul7 commented 4 years ago

app:mbn_circleColor="#E4E4E4"

use this, I am sorry, I provided the wrong code earlier

ghysuparna commented 4 years ago

app:mbn_circleColor="#E4E4E4"

use this, I am sorry, I provided the wrong code earlier

I tried with this but i think owner has removed this attribute as I m getting this error "mbn_circleColor (aka com.example.portfolioinandroid:mbn_circleColor) not found".

iabduul7 commented 4 years ago

yeah I think it is removed in latest version and by the way I used version 1.2.0 as I was encountering this icon size issue, so I'd recommend you to the use the same until this issue fixed

ghysuparna commented 4 years ago

yeah I think it is removed in latest version and by the way I used version 1.2.0 as I was encountering this icon size issue, so I'd recommend you to the use the same until this issue fixed

Thanks it worked finally. with version 1.2.0, also I got icon size issue in latest version

iabduul7 commented 4 years ago

yeah I think it is removed in latest version and by the way I used version 1.2.0 as I was encountering this icon size issue, so I'd recommend you to the use the same until this issue fixed

Thanks it worked finally. with version 1.2.0, also I got icon size issue in latest version

I am glade your issue is resolved

oneHamidreza commented 4 years ago

send your codes

iabduul7 commented 4 years ago

send your codes

I tried using the very same code that you mentioned in README file. The issue was with the latest version.

pratikchevli commented 4 years ago

yess the icon is too small and even cant click on them because of that

vinaykharayat commented 4 years ago

I am also facing same issue!

Screenshot_2020-09-06-11-15-35-550_com.androboot.bottomnavigation.jpg

iabduul7 commented 4 years ago

Kindly try using version 1.2.0 until the issue is fixed

thelittlefireman commented 3 years ago

Same issue

implementation 'com.etebarian:meow-bottom-navigation:1.3.1'

mBottomNavigationView.add(new MeowBottomNavigation.Model(ID_EDT, R.drawable.ic_event_black_24dp));
        mBottomNavigationView.add(new MeowBottomNavigation.Model(ID_MAPS, R.drawable.ic_map_black_24dp));
        mBottomNavigationView.add(new MeowBottomNavigation.Model(ID_CROUS, R.drawable.ic_restaurant_menu_black_24dp));
        mBottomNavigationView.setOnClickMenuListener(model -> {
            mViewPager.setCurrentItem(model.getId());
            return null;
        });
 mBottomNavigationView.show(ID_EDT, false);
       <meow.bottomnavigation.MeowBottomNavigation
            android:background="@drawable/background_navigation_bottom_view"
            android:id="@+id/bottom_navigation"
            android:layout_height="wrap_content"
            android:layout_marginEnd="0dp"
            android:layout_marginStart="0dp"
            android:layout_width="0dp"
            app:elevation="8dp"
            app:layout_constraintBottom_toBottomOf="parent"
            app:layout_constraintLeft_toLeftOf="parent"
            app:layout_constraintRight_toRightOf="parent"
            app:layout_constraintTop_toBottomOf="@+id/appodealBannerViewMain"
            app:menu="@menu/bottom_navigation" />
Mikeni12 commented 3 years ago

I was checking the master branch and it works great, but when I added the implementation to the Gradle I faced the same issue.

I think the version from the implementation is not correct because in the manifest the version name differs (1.3.1) and also the attribute 'mbn_hasAnimation' doesn't exist as in the master branch.

Captura de Pantalla 2020-09-27 a la(s) 0 54 10

ihassanali259 commented 3 years ago

Kindly try using version 1.2.0 until the issue is fixed

I have used this version but the icons colors are changed to gray automatically

iabduul7 commented 3 years ago

Kindly try using version 1.2.0 until the issue is fixed

I have used this version but the icons colors are changed to gray automatically

no, that shouldn't be the behavior.

iabduul7 commented 3 years ago

can you please post your XML code?

ihassanali259 commented 3 years ago

can you please post your XML code? Sorry, my bad. I was using custom icons that the designer gave me. But I forgot to add bottomnavbar.itemIconTintList = null. It's working fine now

abkoradiya commented 3 years ago

I am facing same issue now.

How can you release guys without testing it once? Also, I can't found tag or commit not for release 2.1.0

rajamama commented 3 years ago

Icons are very small and not visible to click (am using java code), any idea when we can get some update on the fix @oneHamidreza

mohamedagamy commented 3 years ago

the same problem here

ShafiqSadat commented 3 years ago

same here

HimaniT07 commented 3 years ago

same issue

ahuamana commented 3 years ago

use older version implementation 'com.etebarian:meow-bottom-navigation:1.2.0'