search

oneVR / VRWorldToolkit

Unity Editor extension for making VRChat worlds
MIT License
419 stars 19 forks source link

(VPM) Unspecified `com.unity.postprocessing` dependency #18

Closed rrazgriz closed 1 year ago

rrazgriz commented 1 year ago

The vpm branch relies on the package com.unity.postprocessing being present, but the package is not listed as a dependency. This causes issues when importing to a base Avatars VCC project, as the Avatars SDK package does not contain com.unity.postprocessing as a dependency, but the Worlds SDK package does. Unity_fhSkqD8oNF

Define guards are present on the master branch, with a menu item for importing the post-processing package: https://github.com/oneVR/VRWorldToolkit/blob/master/Scripts/Editor/WorldDebugger.cs#L10 https://github.com/oneVR/VRWorldToolkit/blob/master/Scripts/Editor/PostProcessingTools.cs#L6

These have been removed in the vpm branch: https://github.com/oneVR/VRWorldToolkit/blob/vpm/Editor/WorldDebugger.cs#L23 https://github.com/oneVR/VRWorldToolkit/blob/vpm/Editor/PostProcessingTools.cs#L6

This can be fixed either by re-adding the define guards and menu option, or by adding com.unity.postprocessing as a dependency.

oneVR commented 1 year ago

Thank you for the report and PR! Merged #19