oneall / social-login-phpbb

Social Login for phpBB allows your users to login and register with 40+ social networks. It increases your phpBB user registration rate by simplifying the registration process.
https://docs.oneall.com/plugins/guide/social-login-phpbb/
52 stars 33 forks source link

oneall/library.js loaded on all pages when not used #79

Open diegaless opened 3 years ago

diegaless commented 3 years ago

phpbb 3.3 - Social Login 4.7.2

I use phpbb 3.3 and from the ACP configure that oneall social login is only shown in the index. This is correct, visually it only appears in this one, however, the script is loaded in each and every one of the pages (topics, subforums, etc.), even if it is not shown. I don't know if this is a general behavior of the api (I would be surprised) or if it is a bug. This in itself is critical, since although oneall is distributed from a CDN, the latency is great especially in some locations + - 1s.

I hope someone can shed light on the matter.

Specifically this is the part of the script that is loaded and to which I refer:

`<!-- OneAll Social Login : http://www.oneall.com //-->
        <script type="text/javascript">//<![CDATA[(function(){var oa=document.createElement('script');oa.type='text/javascript';oa.async=true;oa.src='//editedforprivacy.api.oneall.com/socialize/library.js';var s=document.getElementsByTagName('script')[0];s.parentNode.insertBefore(oa,s);})();//]]></script>`